EA Code

I don't which section to post this in. Hopefully this is the right one.
I am busy coding an EA (with my limited knowledge )
Here is one issue I can't seem to solve, obviously it works perfectly with the EA running on only 1 currency pair, but as soon as I drop it on another pair, I run into the following problems, I know it's just a stupid coding mistake on my side:
-------------------
I have set the maximum trades to 1, so it doesn't open
more than 1 buy or 1 sell.
This works fine, but if I drop the EA on a 2nd pair, it doesn't take trades, unless I change the 2nd MagicNumber to something different.
This is not a real issue, as I can just assign a new magic number to every currency pair. It would just be nice if I don't need 5 different magic numbers for the same EA on 5 pairs

The big issue I have is partial take profit.
It works fine on 1 pair, closes perfectly, BUT if I drop on pair number 2, it uses the 1st next tick to calculate the value the 2nd pair's value, and obviously it uses the wrong pair's value to partly close the other pair.


//  add your notes here ...
if ( ( Use_Partial_TP == true ))
{
SellPTP=OrderOpenPrice()-(Partial_TP* Point);
if ( ( OrderLots() == Lots ) || ( OrderLots() == _MMLots ))
{
if ( ( Ask <= SellPTP ))
{
for( int pos6030=0;pos6030<OrdersTotal();pos6030++)
{
if(OrderSelect(pos6030,SELECT_BY_POS)==false) continue;
if( ( OrderTicket() == _OrderTicketEA) )
{
double price6198=0;

price6198 = MarketInfo(OrderSymbol(), MODE_ASK);

_fnCloseSellPTP = OrderClose(  OrderTicket(), (OrderLots()/2), price6198, Slippage, White );
if( _fnCloseSellPTP == false )
Print("OrderClose error=", GetLastError());

Coding for buy is basically the same except Add to the open price, and close price is Bid, etc etc.
And it does this besides the fact that the same EA runs on both pairs, but different magic numbers, which is why I am totally stumped, I was under the impression if I assign different magics, it will solve this problem too.

Thanks for the help again.
Francois




Linkback: https://www.forex.zone/ea-modifications/17/ea-code/332/

I am sure both problems are related. If you haven't solved this yet, I would want to see the entire code. For example, I do not see how you are determining the value for the '_OrderTicketEA' variable. If you are not considering order symbol correctly then the wrong ticket could be assigned to this variable. 

Also, just a tip, but don't cycle through orders the way you do. It's better to do it like this:
for(int pos6030=OrdersTotal()-1;pos6030>=0;pos6030--)

I think it's better to post the code.
You will very likely not be happy with the way it is coded, as most of the coding is done by the wysiwyg software.
This is a template I am created to use the most rules I apply to a trade, ie, Use MoneyManagement (bool), Use Partial Take Profit (The BuyPTP and SellPTP), Use TradeTime(As you can see I only used the Hour()),
New Candle only trading.
The signal to enter a trade is just a plain 0==0, to just enter trades to see if the functions work.
Like I said, on 1 pair, it works fine, but add another, and all confusion starts.
 

Regarding the Partial TP problem, the code you posted before does not match the code in the EA you attached afterwards.

Here is the code from the EA you attached from line 1406:
if( ( OrderType() == OP_SELL) && ( OrderMagicNumber() == MagicNumber) && ( OrderSymbol() == Symbol()) )

In the code you posted before, it just has:
if( ( OrderTicket() == _OrderTicketEA) )

 There are other mismatches in the code, but this is the most important which is related to the problem. I think if you test the code in the EA attached, it will work better than the code that you posted before.

I think if you test the code in the EA attached, it will work better than the code that you posted before.

Hi, I can't find it, please re-attach your code. Thanks

Do I need to assign a Partial TP (BuyPTP and SellPTP) Variabale to each pair?

No, I wouldn't do this.

I only use BuyPTP and SellPTP now, and  the EA assigns a value to them based on the first opened trade.  So if it opens a EURUSD trade, it writes the value, if it opens a GBPUSD trade after that, it doesn't get a new value for GBPUSD and assigns EURUSD's BuyPTP to GBPUSD as well.

This is the problem. The EA was not coded to recognize trades properly.

This is the code from your EA from lines 1353-1355:
_OrderSelectEA = OrderSelect(  0, _OrderTicketEA, 0 );
//  Returns ticket number for the currently selected order.//                          Note: The order must be previously selected by the OrderSelect() function.//                      //  Sample//  //                          if(OrderSelect(12, SELECT_BY_POS)==true)//                          order=OrderTicket();//                          else//                          Print("OrderSelect failed error code is",GetLastError());
_OrderTicketEA = OrderTicket();

I'm sorry to say, but this is totally not done right. First, you have a '0' for the first parameter in this function. Which means the selected order will be taken from the position in the order pool, but not by a ticket number. Yet, the 2nd parameter is supposed to be a ticket number based on the name. Also, the 3rd parameter is a '0' which means you will be selecting currently open orders, but this value is useless when selecting by ticket number. 

Also, you have '_OrderTicketEA' for the 2nd parameter, but the next line sets this variable with the ticket number from the order just selected. So you can basically just input a 0 for the 2nd parameter and it will accomplish the same thing. Actually, you can just have the EA pick any trade randomly and it will work just as well, because your EA is not filtering out any trades at all.

The reason I am mentioning the above lines of code is because later in the EA for the 'BuyPTP', it needs the correct information. 

From line 1564:
BuyPTP=_OrderOpenPriceEA+(Partial_TP* Point);

The root of your BuyPTP problem is that the EA is not getting the correct information for the open price to start with. The EA needs to select the correct order. So it needs to filter out trades that it shouldn't be considering. Once it selects the correct order then it will have the accurate information it needs for the rest of the code.

There are a couple things I would do differently.

First, in line 47 you should have a '{' after the if statement. And then a matching close '}' later.

Also, you have this code:
if (!(OrderType()==OP_BUY) && (OrderSymbol()== Symbol())&& (OrderMagicNumber()==Magic))

If you want to alert if there is no trade from this EA open, it would be better to do it like this:
if (!(OrderType()==OP_BUY && OrderSymbol()==Symbol() && OrderMagicNumber()==Magic))
That way, all 3 conditions need to be false in order to alert and not just the 1st condition.

If you use a not hidden SL then you can use the following in the TrailingStop function:


double SLBuyDynamic = (low2-(MarketInfo(NULL,MODE_STOPLEVEL))*(MarketInfo(NULL,MODE_POINT)));
           
            if(OrderType()==OP_BUY && OrderStopLoss()>SLBuyDynamic){
                 SLBuyDynamic = OrderStopLoss();
            }

 double SLSellDynamic = (hi+(MarketInfo(NULL,MODE_STOPLEVEL))*(MarketInfo(NULL,MODE_POINT)));
           
            if(OrderType()==OP_SELL && OrderStopLoss()>0 && OrderStopLoss()<SLSellDynamic){
                  SLSellDynamic = OrderStopLoss();
             }